OSDN Git Service

Fix LinkPropertiesTest.testCompareResult
authorRubin Xu <rubinxu@google.com>
Fri, 15 Sep 2017 10:51:39 +0000 (11:51 +0100)
committerRubin Xu <rubinxu@google.com>
Fri, 15 Sep 2017 10:55:28 +0000 (11:55 +0100)
Test: runtest frameworks-core -c android.net.LinkPropertiesTest
Change-Id: Ie97b7a7a1557b14296d7c33e98991cdede8463b0

core/tests/coretests/src/android/net/LinkPropertiesTest.java

index bc2b9a6..1cb0ecd 100644 (file)
@@ -753,7 +753,7 @@ public class LinkPropertiesTest extends TestCase {
     @SmallTest
     public void testCompareResult() {
         // Either adding or removing items
-        testCompareResult(Arrays.asList(1), Arrays.asList(1, 2, 3, 4),
+        testCompareResult(Arrays.asList(1, 2, 3, 4), Arrays.asList(1),
                 Arrays.asList(2, 3, 4), new ArrayList<>());
         testCompareResult(Arrays.asList(1, 2), Arrays.asList(3, 2, 1, 4),
                 new ArrayList<>(), Arrays.asList(3, 4));
@@ -780,9 +780,9 @@ public class LinkPropertiesTest extends TestCase {
         assertEquals(expectedSet, actualSet);
     }
 
-    private <T> void testCompareResult(List<T> oldItems, List<T> newItems, List<T> expectAdded,
-            List<T> expectRemoved) {
-        CompareResult<T> result = new CompareResult<>(newItems, oldItems);
+    private <T> void testCompareResult(List<T> oldItems, List<T> newItems, List<T> expectRemoved,
+            List<T> expectAdded) {
+        CompareResult<T> result = new CompareResult<>(oldItems, newItems);
         assertEquals(new ArraySet<>(expectAdded), new ArraySet<>(result.added));
         assertEquals(new ArraySet<>(expectRemoved), (new ArraySet<>(result.removed)));
     }