OSDN Git Service

Input: tca8418_keypad - remove double read of key event register
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 13 Feb 2017 23:45:59 +0000 (15:45 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 23 Feb 2017 17:21:30 +0000 (09:21 -0800)
There is no need to tread the same register twice in a row.

Fixes: ea4348c8462a ("Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-un ...")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/tca8418_keypad.c

index 44dd768..e37e335 100644 (file)
@@ -188,8 +188,6 @@ static void tca8418_read_keypad(struct tca8418_keypad *keypad_data)
                input_event(input, EV_MSC, MSC_SCAN, code);
                input_report_key(input, keymap[code], state);
 
-               /* Read for next loop */
-               error = tca8418_read_byte(keypad_data, REG_KEY_EVENT_A, &reg);
        } while (1);
 
        input_sync(input);