OSDN Git Service

net: ipa: use version in gsi_channel_reset()
authorAlex Elder <elder@linaro.org>
Mon, 2 Nov 2020 17:53:58 +0000 (11:53 -0600)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Nov 2020 00:28:04 +0000 (16:28 -0800)
A quirk of IPA v3.5.1 requires a channel reset on an RX channel to
be performed twice.  Use the IPA version in gsi_channel_reset()
rather than the passed-in legacy flag to determine that.

This is actually a bug fix, because this double reset is supposed
to occur independent of whether we're enabling the doorbell engine.
Now they will be independent.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/gsi.c

index eae8ed8..729ef71 100644 (file)
@@ -840,7 +840,7 @@ void gsi_channel_reset(struct gsi *gsi, u32 channel_id, bool legacy)
 
        gsi_channel_reset_command(channel);
        /* Due to a hardware quirk we may need to reset RX channels twice. */
-       if (legacy && !channel->toward_ipa)
+       if (gsi->version == IPA_VERSION_3_5_1 && !channel->toward_ipa)
                gsi_channel_reset_command(channel);
 
        gsi_channel_program(channel, legacy);