OSDN Git Service

octeontx2-af: remove redudant second error check on variable err
authorColin Ian King <colin.king@canonical.com>
Wed, 18 Aug 2021 13:09:27 +0000 (14:09 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Aug 2021 19:18:51 +0000 (12:18 -0700)
A recent change added error checking messages and failed to remove one
of the previous error checks. There are now two checks on variable err
so the second one is redundant dead code and can be removed.

Addresses-Coverity: ("Logically dead code")
Fixes: a83bdada06bf ("octeontx2-af: Add debug messages for failures")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210818130927.33895-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/rvu.c

index fb50df9..c2438ba 100644 (file)
@@ -1031,8 +1031,6 @@ cpt:
                        "%s: Failed to allocate CPT1 LF bitmap\n", __func__);
                return err;
        }
-       if (err)
-               return err;
 
        /* Allocate memory for PFVF data */
        rvu->pf = devm_kcalloc(rvu->dev, hw->total_pfs,