OSDN Git Service

is_refname_available(): avoid shadowing "dir" variable
authorMichael Haggerty <mhagger@alum.mit.edu>
Mon, 11 May 2015 15:25:05 +0000 (17:25 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 11 May 2015 18:50:17 +0000 (11:50 -0700)
The function had a "dir" parameter that was shadowed by a local "dir"
variable within a code block. Use the former in place of the latter.
(This is consistent with "dir"'s use elsewhere in the function.)

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
refs.c

diff --git a/refs.c b/refs.c
index 776bbce..9d87e84 100644 (file)
--- a/refs.c
+++ b/refs.c
@@ -967,10 +967,10 @@ static int is_refname_available(const char *refname,
                 * "refs/foo/bar/"). It is a problem iff it contains
                 * any ref that is not in "skip".
                 */
-               struct ref_entry *entry = dir->entries[pos];
-               struct ref_dir *dir = get_ref_dir(entry);
                struct nonmatching_ref_data data;
+               struct ref_entry *entry = dir->entries[pos];
 
+               dir = get_ref_dir(entry);
                data.skip = skip;
                sort_ref_dir(dir);
                if (!do_for_each_entry_in_dir(dir, 0, nonmatching_ref_fn, &data))