OSDN Git Service
(root)
/
android-x86
/
kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dd5619c
)
pciehp: Remove unnecessary check in pciehp_ctrl.c
author
Eric Sesterhenn
<snakebyte@gmx.de>
Sun, 24 Sep 2006 22:56:53 +0000
(
00:56
+0200)
committer
Greg Kroah-Hartman
<gregkh@suse.de>
Wed, 18 Oct 2006 18:36:10 +0000
(11:36 -0700)
this was spotted by coverity (cid #819). We dereference p_slot
earlier in the function, and i found no way it could become NULL
anywhere.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/hotplug/pciehp_ctrl.c
patch
|
blob
|
history
diff --git
a/drivers/pci/hotplug/pciehp_ctrl.c
b/drivers/pci/hotplug/pciehp_ctrl.c
index
c206a3d
..
372c63e
100644
(file)
--- a/
drivers/pci/hotplug/pciehp_ctrl.c
+++ b/
drivers/pci/hotplug/pciehp_ctrl.c
@@
-797,8
+797,7
@@
int pciehp_enable_slot(struct slot *p_slot)
p_slot->hpc_ops->get_latch_status(p_slot, &getstatus);
}
- if (p_slot)
- update_slot_info(p_slot);
+ update_slot_info(p_slot);
mutex_unlock(&p_slot->ctrl->crit_sect);
return rc;