OSDN Git Service

usb: gadget: cleanup on stack DECLARE_COMPLETIONs
authorNicholas Mc Guire <der.herr@hofr.at>
Tue, 23 Dec 2014 18:50:14 +0000 (19:50 +0100)
committerFelipe Balbi <balbi@ti.com>
Mon, 12 Jan 2015 18:13:27 +0000 (12:13 -0600)
fixups for incorrect use of DECLARE_COMPLETION. see also commit
6e9a4738 ("completions: lockdep annotate on stack completions")

patch is against 3.18.0 linux-next

This was only code reviewed and compile tested

Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/udc/fsl_qe_udc.c
drivers/usb/gadget/udc/fsl_udc_core.c

index 795c99c..e0822f1 100644 (file)
@@ -2630,7 +2630,7 @@ static int qe_udc_remove(struct platform_device *ofdev)
        struct qe_udc *udc = platform_get_drvdata(ofdev);
        struct qe_ep *ep;
        unsigned int size;
-       DECLARE_COMPLETION(done);
+       DECLARE_COMPLETION_ONSTACK(done);
 
        usb_del_gadget_udc(&udc->gadget);
 
index 2df8074..c3830ad 100644 (file)
@@ -2529,7 +2529,7 @@ static int __exit fsl_udc_remove(struct platform_device *pdev)
        struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        struct fsl_usb2_platform_data *pdata = dev_get_platdata(&pdev->dev);
 
-       DECLARE_COMPLETION(done);
+       DECLARE_COMPLETION_ONSTACK(done);
 
        if (!udc_controller)
                return -ENODEV;