compute hash only once depending on algorithm in digestMd5ResponseHelper()

Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>

diff --git a/src/network/kernel/qauthenticator.cpp b/src/network/kernel/qauthenticator.cpp
index 86423fc..e4de595 100644 (file)
--- a/src/network/kernel/qauthenticator.cpp
+++ b/src/network/kernel/qauthenticator.cpp
@@ -568,14 +568,8 @@ static QByteArray digestMd5ResponseHelper(
     )
 {
     QCryptographicHash hash(QCryptographicHash::Md5);
-    hash.addData(userName);
-    hash.addData(":", 1);
-    hash.addData(realm);
-    hash.addData(":", 1);
-    hash.addData(password);
-    QByteArray ha1 = hash.result();
+    QByteArray ha1;
     if (alg.toLower() == "md5-sess") {
-        hash.reset();
         // RFC 2617 contains an error, it was:
         // hash.addData(ha1);
         // but according to the errata page at http://www.rfc-editor.org/errata_list.php, ID 1649, it
@@ -586,6 +580,13 @@ static QByteArray digestMd5ResponseHelper(
         hash.addData(":", 1);
         hash.addData(cNonce);
         ha1 = hash.result();
+    } else {
+        hash.addData(userName);
+        hash.addData(":", 1);
+        hash.addData(realm);
+        hash.addData(":", 1);
+        hash.addData(password);
+        ha1 = hash.result();
     };
     ha1 = ha1.toHex();