OSDN Git Service

Merge pull request #79 from emaiannone/refactoring/aDoctor
authorBraden Farmer <farmerbb@gmail.com>
Sat, 18 Jan 2020 04:20:47 +0000 (21:20 -0700)
committerGitHub <noreply@github.com>
Sat, 18 Jan 2020 04:20:47 +0000 (21:20 -0700)
Refactor Member Ignoring Method smell in IconPack class

app/src/main/java/com/farmerbb/taskbar/util/IconPack.java

index 77fc9dd..783c46c 100644 (file)
@@ -282,16 +282,14 @@ public class IconPack {
         return result;
     }
 
-    private long generateSeed(String packageName) {
-        long seed = 0;
-
-        for(int i = 0; i < packageName.length(); i++) {
-            char ch = packageName.charAt(i);
-            seed = seed + (long) ch;
-        }
-
-        return seed;
-    }
+    private static long generateSeed(String packageName) {
+               long seed = 0;
+               for (int i = 0; i < packageName.length(); i++) {
+                       char ch = packageName.charAt(i);
+                       seed = seed + (long) ch;
+               }
+               return seed;
+       }
     
     private Resources getResources(Context context) {
         if(iconPackres == null)