OSDN Git Service

usb: cdnsp: fixes undefined reference to cdns_remove
authorPawel Laszczak <pawell@cadence.com>
Wed, 13 Jan 2021 14:14:07 +0000 (15:14 +0100)
committerPeter Chen <peter.chen@kernel.org>
Thu, 14 Jan 2021 01:02:00 +0000 (09:02 +0800)
Patch fixes the following errors:
ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_remove':
cdnsp-pci.c:(.text+0x80): undefined reference to `cdns_remove'
ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_probe':
cdnsp-pci.c:(.text+0x34c): undefined reference to `cdns_init'

Issue occurs for USB/CDNS3/CDNSP kernel configuration:
CONFIG_USB=m
CONFIG_USB_CDNS_SUPPORT=y
CONFIG_USB_CDNS3=m
CONFIG_USB_CDNS3_PCI_WRAP=m
CONFIG_USB_CDNSP_PCI=y

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Peter Chen <peter.chen@kernel.org>
drivers/usb/cdns3/Makefile

index 3f9b7fa..61edb2f 100644 (file)
@@ -26,7 +26,15 @@ obj-$(CONFIG_USB_CDNS3_TI)                   += cdns3-ti.o
 obj-$(CONFIG_USB_CDNS3_IMX)                    += cdns3-imx.o
 
 cdnsp-udc-pci-y                                        := cdnsp-pci.o
+
+ifdef CONFIG_USB_CDNSP_PCI
+ifeq ($(CONFIG_USB),m)
+obj-m                                          += cdnsp-udc-pci.o
+else
 obj-$(CONFIG_USB_CDNSP_PCI)                    += cdnsp-udc-pci.o
+endif
+endif
+
 cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET)       += cdnsp-ring.o cdnsp-gadget.o \
                                                   cdnsp-mem.o cdnsp-ep0.o