OSDN Git Service

scsi: cxlflash: Fix an error handling path in 'cxlflash_disk_attach()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 15 Aug 2017 20:18:14 +0000 (22:18 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Aug 2017 02:28:54 +0000 (22:28 -0400)
'rc' is known to be 0 at this point.  If 'create_context()' fails,
returns -ENOMEM instead of 0 which means success.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxlflash/superpipe.c

index ad0f996..08da593 100644 (file)
@@ -1390,6 +1390,7 @@ static int cxlflash_disk_attach(struct scsi_device *sdev,
        if (unlikely(!ctxi)) {
                dev_err(dev, "%s: Failed to create context ctxid=%d\n",
                        __func__, ctxid);
+               rc = -ENOMEM;
                goto err;
        }