OSDN Git Service

mt76: testmode: move chip-specific stats dump before common stats
authorShayne Chen <shayne.chen@mediatek.com>
Tue, 8 Jun 2021 06:55:57 +0000 (14:55 +0800)
committerFelix Fietkau <nbd@nbd.name>
Sat, 19 Jun 2021 07:22:49 +0000 (09:22 +0200)
Move chip-specific stats dumping part before common stats dumping
to provide flexibility for per-chip driver to modify the value of
common stats.

Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/testmode.c

index c6a85a0..f73ffbd 100644 (file)
@@ -521,6 +521,14 @@ mt76_testmode_dump_stats(struct mt76_phy *phy, struct sk_buff *msg)
        u64 rx_fcs_error = 0;
        int i;
 
+       if (dev->test_ops->dump_stats) {
+               int ret;
+
+               ret = dev->test_ops->dump_stats(phy, msg);
+               if (ret)
+                       return ret;
+       }
+
        for (i = 0; i < ARRAY_SIZE(td->rx_stats.packets); i++) {
                rx_packets += td->rx_stats.packets[i];
                rx_fcs_error += td->rx_stats.fcs_error[i];
@@ -535,9 +543,6 @@ mt76_testmode_dump_stats(struct mt76_phy *phy, struct sk_buff *msg)
                              MT76_TM_STATS_ATTR_PAD))
                return -EMSGSIZE;
 
-       if (dev->test_ops->dump_stats)
-               return dev->test_ops->dump_stats(phy, msg);
-
        return 0;
 }