OSDN Git Service

staging: unisys: use local variable
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Tue, 24 Mar 2015 15:17:27 +0000 (20:47 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Mar 2015 23:01:23 +0000 (00:01 +0100)
we are getting dev_t as an argument in the function, so use the local
variable instead of the global variable "majordev".
this global variable will be removed in one of the next patch of the
series.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorchipset/file.c

index b426762..6ebe7f7 100644 (file)
@@ -57,16 +57,16 @@ visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
        majordev = major_dev;
        cdev_init(&file_cdev, &visorchipset_fops);
        file_cdev.owner = THIS_MODULE;
-       if (MAJOR(majordev) == 0) {
+       if (MAJOR(major_dev) == 0) {
                /* dynamic major device number registration required */
-               if (alloc_chrdev_region(&majordev, 0, 1, MYDRVNAME) < 0)
+               if (alloc_chrdev_region(&major_dev, 0, 1, MYDRVNAME) < 0)
                        return -1;
        } else {
                /* static major device number registration required */
-               if (register_chrdev_region(majordev, 1, MYDRVNAME) < 0)
+               if (register_chrdev_region(major_dev, 1, MYDRVNAME) < 0)
                        return -1;
        }
-       rc = cdev_add(&file_cdev, MKDEV(MAJOR(majordev), 0), 1);
+       rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1);
        if (rc  < 0)
                return -1;
        return 0;