OSDN Git Service

Bluetooth: hidp: fix buffer overflow
authorYoung Xiao <YangX92@hotmail.com>
Fri, 12 Apr 2019 07:24:30 +0000 (15:24 +0800)
committerMarcel Holtmann <marcel@holtmann.org>
Tue, 23 Apr 2019 17:04:38 +0000 (19:04 +0200)
Struct ca is copied from userspace. It is not checked whether the "name"
field is NULL terminated, which allows local users to obtain potentially
sensitive information from kernel stack memory, via a HIDPCONNADD command.

This vulnerability is similar to CVE-2011-1079.

Signed-off-by: Young Xiao <YangX92@hotmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
net/bluetooth/hidp/sock.c

index 9f85a19..2151913 100644 (file)
@@ -75,6 +75,7 @@ static int do_hidp_sock_ioctl(struct socket *sock, unsigned int cmd, void __user
                        sockfd_put(csock);
                        return err;
                }
+               ca.name[sizeof(ca.name)-1] = 0;
 
                err = hidp_connection_add(&ca, csock, isock);
                if (!err && copy_to_user(argp, &ca, sizeof(ca)))