OSDN Git Service

staging: hv: remove ASSERT()s and return -EINVAL in RingBuffer.c
authorBill Pemberton <wfp5p@virginia.edu>
Wed, 5 May 2010 19:27:50 +0000 (15:27 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 11 May 2010 18:36:14 +0000 (11:36 -0700)
return -EINVAL instead of calling ASSERT() for these conditionals.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/hv/RingBuffer.c

index 69f3eba..64f8d0f 100644 (file)
@@ -490,7 +490,8 @@ int RingBufferRead(RING_BUFFER_INFO *InRingInfo, void *Buffer,
        u64 prevIndices = 0;
        unsigned long flags;
 
-       ASSERT(BufferLen > 0);
+       if (BufferLen <= 0)
+               return -EINVAL;
 
        spin_lock_irqsave(&InRingInfo->ring_lock, flags);