OSDN Git Service

[SCSI] libsas: fix test for negative unsigned and typos
authorRoel Kluin <roel.kluin@gmail.com>
Fri, 2 Jan 2009 16:32:55 +0000 (17:32 +0100)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Fri, 2 Jan 2009 18:16:38 +0000 (12:16 -0600)
unsigned req->data_len cannot be negative, and fix =-/-= typo

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/libsas/sas_host_smp.c

index 16f9312..d110a36 100644 (file)
@@ -199,8 +199,8 @@ int sas_smp_host_handler(struct Scsi_Host *shost, struct request *req,
                break;
 
        case SMP_DISCOVER:
-               req->data_len =- 16;
-               if (req->data_len < 0) {
+               req->data_len -= 16;
+               if ((int)req->data_len < 0) {
                        req->data_len = 0;
                        error = -EINVAL;
                        goto out;
@@ -215,8 +215,8 @@ int sas_smp_host_handler(struct Scsi_Host *shost, struct request *req,
                break;
 
        case SMP_REPORT_PHY_SATA:
-               req->data_len =- 16;
-               if (req->data_len < 0) {
+               req->data_len -= 16;
+               if ((int)req->data_len < 0) {
                        req->data_len = 0;
                        error = -EINVAL;
                        goto out;
@@ -238,8 +238,8 @@ int sas_smp_host_handler(struct Scsi_Host *shost, struct request *req,
                break;
 
        case SMP_PHY_CONTROL:
-               req->data_len =- 44;
-               if (req->data_len < 0) {
+               req->data_len -= 44;
+               if ((int)req->data_len < 0) {
                        req->data_len = 0;
                        error = -EINVAL;
                        goto out;