OSDN Git Service

phy: ti: phy-j721e-wiz: fix reference leaks in wiz_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 22 Sep 2022 11:21:07 +0000 (14:21 +0300)
committerVinod Koul <vkoul@kernel.org>
Sat, 24 Sep 2022 06:29:37 +0000 (11:59 +0530)
These two error paths need to call of_node_put(child_node) before
returning.

Fixes: edd473d4293a ("phy: ti: phy-j721e-wiz: add support for j7200-wiz-10g")
Fixes: 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/YyxFI8aW23IC/21U@kili
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-j721e-wiz.c

index 1f4f585..41725c6 100644 (file)
@@ -1413,7 +1413,8 @@ static int wiz_probe(struct platform_device *pdev)
        if (IS_ERR(wiz->scm_regmap)) {
                if (wiz->type == J7200_WIZ_10G) {
                        dev_err(dev, "Couldn't get ti,scm regmap\n");
-                       return -ENODEV;
+                       ret = -ENODEV;
+                       goto err_addr_to_resource;
                }
 
                wiz->scm_regmap = NULL;
@@ -1463,7 +1464,7 @@ static int wiz_probe(struct platform_device *pdev)
 
        ret = wiz_get_lane_phy_types(dev, wiz);
        if (ret)
-               return ret;
+               goto err_addr_to_resource;
 
        wiz->dev = dev;
        wiz->regmap = regmap;