OSDN Git Service

PCI: rcar: Do not shadow the 'irq' variable
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sun, 17 Mar 2019 09:34:45 +0000 (10:34 +0100)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 4 Apr 2019 10:49:07 +0000 (11:49 +0100)
The sparse tool rightfully detects:
drivers/pci/controller/pcie-rcar.c:741:30: warning: symbol 'irq' shadows an earlier one

Fix it now to avoid future surprises and for good coding style.

No functional change intended.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[lorenzo.pieralisi@arm.com: commit log refactoring]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
drivers/pci/controller/pcie-rcar.c

index 0004b64..e4cebeb 100644 (file)
@@ -738,15 +738,15 @@ static irqreturn_t rcar_pcie_msi_irq(int irq, void *data)
 
        while (reg) {
                unsigned int index = find_first_bit(&reg, 32);
-               unsigned int irq;
+               unsigned int msi_irq;
 
                /* clear the interrupt */
                rcar_pci_write_reg(pcie, 1 << index, PCIEMSIFR);
 
-               irq = irq_find_mapping(msi->domain, index);
-               if (irq) {
+               msi_irq = irq_find_mapping(msi->domain, index);
+               if (msi_irq) {
                        if (test_bit(index, msi->used))
-                               generic_handle_irq(irq);
+                               generic_handle_irq(msi_irq);
                        else
                                dev_info(dev, "unhandled MSI\n");
                } else {