OSDN Git Service

net/iucv: fix indentation in __iucv_message_receive()
authorJulian Wiedmann <jwi@linux.ibm.com>
Thu, 1 Oct 2020 17:21:27 +0000 (19:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 3 Oct 2020 23:51:07 +0000 (16:51 -0700)
smatch complains about
net/iucv/iucv.c:1119 __iucv_message_receive() warn: inconsistent indenting

While touching this line, also make the return logic consistent and thus
get rid of a goto label.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/iucv/iucv.c

index cd2e468..349c6ac 100644 (file)
@@ -1116,10 +1116,9 @@ int __iucv_message_receive(struct iucv_path *path, struct iucv_message *msg,
        if (msg->flags & IUCV_IPRMDATA)
                return iucv_message_receive_iprmdata(path, msg, flags,
                                                     buffer, size, residual);
-        if (cpumask_empty(&iucv_buffer_cpumask)) {
-               rc = -EIO;
-               goto out;
-       }
+       if (cpumask_empty(&iucv_buffer_cpumask))
+               return -EIO;
+
        parm = iucv_param[smp_processor_id()];
        memset(parm, 0, sizeof(union iucv_param));
        parm->db.ipbfadr1 = (u32)(addr_t) buffer;
@@ -1135,7 +1134,6 @@ int __iucv_message_receive(struct iucv_path *path, struct iucv_message *msg,
                if (residual)
                        *residual = parm->db.ipbfln1f;
        }
-out:
        return rc;
 }
 EXPORT_SYMBOL(__iucv_message_receive);