OSDN Git Service

net: ethernet: mediatek: remove superfluous local variable for phy address
authorSean Wang <sean.wang@mediatek.com>
Thu, 22 Sep 2016 08:36:15 +0000 (16:36 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Sep 2016 12:22:27 +0000 (08:22 -0400)
remove the unused variable for parsing PHY address
and the related logic for sanity test which would
be all already handled done when of_mdiobus_register
was called

Reported-by: Nelson Chang <nelson.chang@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mediatek/mtk_eth_soc.c

index 6b7acf4..1918c39 100644 (file)
@@ -226,17 +226,9 @@ static void mtk_phy_link_adjust(struct net_device *dev)
 static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
                                struct device_node *phy_node)
 {
-       const __be32 *_addr = NULL;
        struct phy_device *phydev;
-       int phy_mode, addr;
+       int phy_mode;
 
-       _addr = of_get_property(phy_node, "reg", NULL);
-
-       if (!_addr || (be32_to_cpu(*_addr) >= 0x20)) {
-               pr_err("%s: invalid phy address\n", phy_node->name);
-               return -EINVAL;
-       }
-       addr = be32_to_cpu(*_addr);
        phy_mode = of_get_phy_mode(phy_node);
        if (phy_mode < 0) {
                dev_err(eth->dev, "incorrect phy-mode %d\n", phy_mode);