OSDN Git Service

staging: greybus: Use gpio_is_valid()
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Sat, 28 Apr 2018 04:35:39 +0000 (10:05 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Apr 2018 13:25:52 +0000 (15:25 +0200)
Replace the manual validity checks for the GPIO with the
gpio_is_valid().

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/arche-platform.c

index 8fe8b6e..4c36e88 100644 (file)
@@ -447,7 +447,7 @@ static int arche_platform_probe(struct platform_device *pdev)
        arche_pdata->svc_reset_gpio = of_get_named_gpio(np,
                                                        "svc,reset-gpio",
                                                        0);
-       if (arche_pdata->svc_reset_gpio < 0) {
+       if (!gpio_is_valid(arche_pdata->svc_reset_gpio)) {
                dev_err(dev, "failed to get reset-gpio\n");
                return arche_pdata->svc_reset_gpio;
        }
@@ -467,7 +467,7 @@ static int arche_platform_probe(struct platform_device *pdev)
        arche_pdata->svc_sysboot_gpio = of_get_named_gpio(np,
                                                          "svc,sysboot-gpio",
                                                          0);
-       if (arche_pdata->svc_sysboot_gpio < 0) {
+       if (!gpio_is_valid(arche_pdata->svc_sysboot_gpio)) {
                dev_err(dev, "failed to get sysboot gpio\n");
                return arche_pdata->svc_sysboot_gpio;
        }
@@ -486,7 +486,7 @@ static int arche_platform_probe(struct platform_device *pdev)
        arche_pdata->svc_refclk_req = of_get_named_gpio(np,
                                                        "svc,refclk-req-gpio",
                                                        0);
-       if (arche_pdata->svc_refclk_req < 0) {
+       if (!gpio_is_valid(arche_pdata->svc_refclk_req)) {
                dev_err(dev, "failed to get svc clock-req gpio\n");
                return arche_pdata->svc_refclk_req;
        }