OSDN Git Service

PM / devfreq: Replace strncpy with strscpy
authorDmitry Osipenko <digetx@gmail.com>
Thu, 27 Feb 2020 17:08:54 +0000 (20:08 +0300)
committerChanwoo Choi <cw00.choi@samsung.com>
Thu, 28 May 2020 09:02:39 +0000 (18:02 +0900)
GCC produces this warning when kernel compiled using `make W=1`:

  warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]
  772 |  strncpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);

The strncpy doesn't take care of NULL-termination of the destination
buffer, while the strscpy does.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/devfreq/devfreq.c

index 6fecd11..ef3d2bc 100644 (file)
@@ -768,7 +768,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
        devfreq->dev.release = devfreq_dev_release;
        INIT_LIST_HEAD(&devfreq->node);
        devfreq->profile = profile;
-       strncpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);
+       strscpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);
        devfreq->previous_freq = profile->initial_freq;
        devfreq->last_status.current_frequency = profile->initial_freq;
        devfreq->data = data;