OSDN Git Service

drm/fb_helper: Use min_t() to handle size_t and unsigned long
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 10 Nov 2020 09:01:19 +0000 (10:01 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 10 Nov 2020 09:38:16 +0000 (10:38 +0100)
On arm32:

    drivers/gpu/drm/drm_fb_helper.c: In function ‘fb_read_screen_base’:
    include/linux/minmax.h:18:28: warning: comparison of distinct pointer types lacks a cast
    ...
    drivers/gpu/drm/drm_fb_helper.c:2041:22: note: in expansion of macro ‘min’
     2041 |  size_t alloc_size = min(count, PAGE_SIZE);
  |                      ^~~
    drivers/gpu/drm/drm_fb_helper.c: In function ‘fb_write_screen_base’:
    include/linux/minmax.h:18:28: warning: comparison of distinct pointer types lacks a cast
    ...
    drivers/gpu/drm/drm_fb_helper.c:2115:22: note: in expansion of macro ‘min’
     2115 |  size_t alloc_size = min(count, PAGE_SIZE);
  |                      ^~~

Indeed, on 32-bit size_t is "unsigned int", not "unsigned long".

Fixes: 222ec45f4c69dfa8 ("drm/fb_helper: Support framebuffers in I/O memory")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20201110090119.2667326-1-geert+renesas@glider.be
drivers/gpu/drm/drm_fb_helper.c

index 01ba1da..25edf67 100644 (file)
@@ -2038,7 +2038,7 @@ static ssize_t fb_read_screen_base(struct fb_info *info, char __user *buf, size_
                                   loff_t pos)
 {
        const char __iomem *src = info->screen_base + pos;
-       size_t alloc_size = min(count, PAGE_SIZE);
+       size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
        ssize_t ret = 0;
        int err = 0;
        char *tmp;
@@ -2112,7 +2112,7 @@ static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf
                                    loff_t pos)
 {
        char __iomem *dst = info->screen_base + pos;
-       size_t alloc_size = min(count, PAGE_SIZE);
+       size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
        ssize_t ret = 0;
        int err = 0;
        u8 *tmp;