OSDN Git Service

drm/ast: Remove little-endianism from I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 21 Feb 2023 15:57:42 +0000 (16:57 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 1 Mar 2023 09:28:40 +0000 (10:28 +0100)
Replace one call to ast_io_write16() with two calls to ast_io_write8()
in ast_set_index_reg(). The combined 16-bit-wide write of an index
register and the corresponding data register only works on little-
endian systems. Write both registers independent from each other.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230221155745.27484-2-tzimmermann@suse.de
drivers/gpu/drm/ast/ast_drv.h

index d51b81f..1f46162 100644 (file)
@@ -282,7 +282,9 @@ static inline void ast_set_index_reg(struct ast_private *ast,
                                     uint32_t base, uint8_t index,
                                     uint8_t val)
 {
-       ast_io_write16(ast, base, ((u16)val << 8) | index);
+       ast_io_write8(ast, base, index);
+       ++base;
+       ast_io_write8(ast, base, val);
 }
 
 void ast_set_index_reg_mask(struct ast_private *ast,