OSDN Git Service

staging: rtl8723bs: fix u8 less than zero check
authorColin Ian King <colin.king@canonical.com>
Fri, 23 Feb 2018 15:00:08 +0000 (15:00 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Mar 2018 16:32:36 +0000 (17:32 +0100)
The error variable ret is currently a u8 and so two comparisons
to see if an error return is less than zero will always be false
because ret is unsigned.  Fix this by making ret an int.

Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c

index 51d48de..1e6c587 100644 (file)
@@ -3255,7 +3255,7 @@ static int cfg80211_rtw_sched_scan_start(struct wiphy *wiphy,
 
        struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
        struct  mlme_priv *pmlmepriv = &(padapter->mlmepriv);
-       u8 ret;
+       int ret;
 
        if (padapter->bup == false) {
                DBG_871X("%s: net device is down.\n", __func__);