OSDN Git Service

staging: hfi1: driver: Use setup_timer
authorMuhammad Falak R Wani <falakreyaz@gmail.com>
Sun, 25 Oct 2015 10:43:24 +0000 (16:13 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Oct 2015 08:06:50 +0000 (17:06 +0900)
Use the timer API function setup_timer instead of init_timer, removing
the structure field assignments.

<smpl>

@timer@
expression e1,e2,e3,fn_ptr;
@@
-init_timer(&e1);
+setup_timer(&e1, fn_ptr, e2);
... when != fn_ptr = e3
-e1.function = fn_ptr;
-e1.data = e2;

</smpl>

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rdma/hfi1/driver.c

index c0a5900..ef4e0c5 100644 (file)
@@ -1062,9 +1062,9 @@ void hfi1_set_led_override(struct hfi1_pportdata *ppd, unsigned int val)
         */
        if (atomic_inc_return(&ppd->led_override_timer_active) == 1) {
                /* Need to start timer */
-               init_timer(&ppd->led_override_timer);
-               ppd->led_override_timer.function = run_led_override;
-               ppd->led_override_timer.data = (unsigned long) ppd;
+               setup_timer(&ppd->led_override_timer, run_led_override,
+                               (unsigned long)ppd);
+
                ppd->led_override_timer.expires = jiffies + 1;
                add_timer(&ppd->led_override_timer);
        } else {