EVM: prevent array underflow in evm_write_xattrs()

If the user sets xattr->name[0] to NUL then we would read one character
before the start of the array.  This bug seems harmless as far as I can
see but perhaps it would trigger a warning in KASAN.

Fixes: fa516b66a1bf ("EVM: Allow runtime modification of the set of verified xattrs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>

diff --git a/security/integrity/evm/evm_secfs.c b/security/integrity/evm/evm_secfs.c
index cf5cd30..3cefef3 100644 (file)
--- a/security/integrity/evm/evm_secfs.c
+++ b/security/integrity/evm/evm_secfs.c
@@ -209,7 +209,7 @@ static ssize_t evm_write_xattrs(struct file *file, const char __user *buf,
 
        /* Remove any trailing newline */
        len = strlen(xattr->name);
-       if (xattr->name[len-1] == '\n')
+       if (len && xattr->name[len-1] == '\n')
                xattr->name[len-1] = '\0';
 
        if (strcmp(xattr->name, ".") == 0) {