OSDN Git Service

mailbox: qcom-ipcc: fix incorrect num_chans counting
authorJonathan Marek <jonathan@marek.ca>
Wed, 2 Aug 2023 13:52:22 +0000 (09:52 -0400)
committerJassi Brar <jaswinder.singh@linaro.org>
Tue, 5 Sep 2023 15:11:01 +0000 (10:11 -0500)
Breaking out early when a match is found leads to an incorrect num_chans
value when more than one ipcc mailbox channel is used by the same device.

Fixes: e9d50e4b4d04 ("mailbox: qcom-ipcc: Dynamic alloc for channel arrangement")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/qcom-ipcc.c

index 7e27acf..f597a1b 100644 (file)
@@ -227,10 +227,8 @@ static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc,
                        ret = of_parse_phandle_with_args(client_dn, "mboxes",
                                                "#mbox-cells", j, &curr_ph);
                        of_node_put(curr_ph.np);
-                       if (!ret && curr_ph.np == controller_dn) {
+                       if (!ret && curr_ph.np == controller_dn)
                                ipcc->num_chans++;
-                               break;
-                       }
                }
        }