OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
053d8f6
)
sch_atm: Fix potential NULL deref.
author
David S. Miller
<davem@davemloft.net>
Sun, 12 Sep 2010 18:56:44 +0000
(11:56 -0700)
committer
David S. Miller
<davem@davemloft.net>
Sun, 12 Sep 2010 18:56:44 +0000
(11:56 -0700)
The list_head conversion unearther an unnecessary flow
check. Since flow is always NULL here we don't need to
see if a matching flow exists already.
Reported-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_atm.c
patch
|
blob
|
history
diff --git
a/net/sched/sch_atm.c
b/net/sched/sch_atm.c
index
3406627
..
6318e11
100644
(file)
--- a/
net/sched/sch_atm.c
+++ b/
net/sched/sch_atm.c
@@
-255,10
+255,6
@@
static int atm_tc_change(struct Qdisc *sch, u32 classid, u32 parent,
error = -EINVAL;
goto err_out;
}
- if (!list_empty(&flow->list)) {
- error = -EEXIST;
- goto err_out;
- }
} else {
int i;
unsigned long cl;