OSDN Git Service
(root)
/
android-x86
/
kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
abffd8d
)
ALSA: pcm: Warn if doubly preallocated
author
Takashi Iwai
<tiwai@suse.de>
Tue, 5 Nov 2019 19:10:06 +0000
(20:10 +0100)
committer
Takashi Iwai
<tiwai@suse.de>
Wed, 6 Nov 2019 14:43:34 +0000
(15:43 +0100)
Warn if snd_pcm_lib_preallocate_pages*() is applied to the stream that
has already the preallocated buffers and skip the allocation. It's a
clearly a driver bug.
Link:
https://lore.kernel.org/r/20191105191007.18150-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_memory.c
patch
|
blob
|
history
diff --git
a/sound/core/pcm_memory.c
b/sound/core/pcm_memory.c
index
7600dcd
..
19407f7
100644
(file)
--- a/
sound/core/pcm_memory.c
+++ b/
sound/core/pcm_memory.c
@@
-221,6
+221,8
@@
void snd_pcm_lib_preallocate_pages(struct snd_pcm_substream *substream,
int type, struct device *data,
size_t size, size_t max)
{
+ if (snd_BUG_ON(substream->dma_buffer.dev.type))
+ return;
substream->dma_buffer.dev.type = type;
substream->dma_buffer.dev.dev = data;
snd_pcm_lib_preallocate_pages1(substream, size, max);