OSDN Git Service

iommu/arm-smmu: Delete an unnecessary check before the function call "free_io_pgtable...
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 29 Jun 2015 16:47:43 +0000 (17:47 +0100)
committerJoerg Roedel <jroedel@suse.de>
Mon, 29 Jun 2015 19:57:32 +0000 (21:57 +0200)
The free_io_pgtable_ops() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/arm-smmu-v3.c

index f141301..8e9ec81 100644 (file)
@@ -1389,8 +1389,7 @@ static void arm_smmu_domain_free(struct iommu_domain *domain)
        struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain);
        struct arm_smmu_device *smmu = smmu_domain->smmu;
 
-       if (smmu_domain->pgtbl_ops)
-               free_io_pgtable_ops(smmu_domain->pgtbl_ops);
+       free_io_pgtable_ops(smmu_domain->pgtbl_ops);
 
        /* Free the CD and ASID, if we allocated them */
        if (smmu_domain->stage == ARM_SMMU_DOMAIN_S1) {