OSDN Git Service

brcmfmac: Clarify if using braces.
authorIan Molton <ian@mnementh.co.uk>
Fri, 8 Dec 2017 12:10:28 +0000 (13:10 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 14 Dec 2017 12:40:59 +0000 (14:40 +0200)
Whilst this if () statement is technically correct, it lacks clarity.

Signed-off-by: Ian Molton <ian@mnementh.co.uk>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c

index bff4610..17cdc13 100644 (file)
@@ -746,16 +746,17 @@ int brcmf_sdiod_send_pkt(struct brcmf_sdio_dev *sdiodev,
        if (err)
                return err;
 
-       if (pktq->qlen == 1 || !sdiodev->sg_support)
+       if (pktq->qlen == 1 || !sdiodev->sg_support) {
                skb_queue_walk(pktq, skb) {
                        err = brcmf_sdiod_buff_write(sdiodev, SDIO_FUNC_2,
                                                     addr, skb);
                        if (err)
                                break;
                }
-       else
+       } else {
                err = brcmf_sdiod_sglist_rw(sdiodev, SDIO_FUNC_2, true, addr,
                                            pktq);
+       }
 
        return err;
 }