OSDN Git Service

drm: Make drm_crtc_helper_disable() return void
authorThierry Reding <treding@nvidia.com>
Tue, 29 Apr 2014 09:44:39 +0000 (11:44 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 29 Apr 2014 10:34:33 +0000 (12:34 +0200)
The function can never fail, and always returns 0, so it may just as
well not return anything.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_crtc_helper.c

index 20585cf..a8b78e7 100644 (file)
@@ -381,8 +381,7 @@ done:
 }
 EXPORT_SYMBOL(drm_crtc_helper_set_mode);
 
-
-static int
+static void
 drm_crtc_helper_disable(struct drm_crtc *crtc)
 {
        struct drm_device *dev = crtc->dev;
@@ -411,7 +410,6 @@ drm_crtc_helper_disable(struct drm_crtc *crtc)
        }
 
        __drm_helper_disable_unused_functions(dev);
-       return 0;
 }
 
 /**
@@ -462,7 +460,8 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
                                (int)set->num_connectors, set->x, set->y);
        } else {
                DRM_DEBUG_KMS("[CRTC:%d] [NOFB]\n", set->crtc->base.id);
-               return drm_crtc_helper_disable(set->crtc);
+               drm_crtc_helper_disable(set->crtc);
+               return 0;
        }
 
        dev = set->crtc->dev;