OSDN Git Service
(root)
/
android-x86
/
kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
fedb25e
)
ipmi: Delete an unnecessary check before the function call "cleanup_one_si"
author
Markus Elfring
<elfring@users.sourceforge.net>
Sat, 27 Jun 2015 16:12:14 +0000
(18:12 +0200)
committer
Corey Minyard
<cminyard@mvista.com>
Thu, 3 Sep 2015 20:02:25 +0000
(15:02 -0500)
The cleanup_one_si() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_si_intf.c
patch
|
blob
|
history
diff --git
a/drivers/char/ipmi/ipmi_si_intf.c
b/drivers/char/ipmi/ipmi_si_intf.c
index
b1fdbf7
..
4387bd6
100644
(file)
--- a/
drivers/char/ipmi/ipmi_si_intf.c
+++ b/
drivers/char/ipmi/ipmi_si_intf.c
@@
-2775,9
+2775,7
@@
static int ipmi_remove(struct platform_device *dev)
{
struct smi_info *info = dev_get_drvdata(&dev->dev);
- if (info)
- cleanup_one_si(info);
-
+ cleanup_one_si(info);
return 0;
}