OSDN Git Service

brcmfmac: Delete redundant length check
authorKevin Cernekee <cernekee@chromium.org>
Sun, 17 Sep 2017 04:08:23 +0000 (21:08 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 2 Oct 2017 14:07:00 +0000 (17:07 +0300)
brcmf_fweh_process_event() sets event->datalen to the
endian-swapped value of event_packet->msg.datalen, which is the
same as emsg.datalen.  This length is already validated in
brcmf_fweh_process_event(), so there is no need to check it
again upon dequeuing the event.

Suggested-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c

index 4eb1e1c..27e661f 100644 (file)
@@ -257,11 +257,6 @@ static void brcmf_fweh_event_worker(struct work_struct *work)
                brcmf_dbg_hex_dump(BRCMF_EVENT_ON(), event->data,
                                   min_t(u32, emsg.datalen, 64),
                                   "event payload, len=%d\n", emsg.datalen);
-               if (emsg.datalen > event->datalen) {
-                       brcmf_err("event invalid length header=%d, msg=%d\n",
-                                 event->datalen, emsg.datalen);
-                       goto event_free;
-               }
 
                /* special handling of interface event */
                if (event->code == BRCMF_E_IF) {