OSDN Git Service

spi: spi-mxs: Fix checkpatch issue
authorJingoo Han <jg1.han@samsung.com>
Tue, 2 Sep 2014 02:50:48 +0000 (11:50 +0900)
committerMark Brown <broonie@kernel.org>
Tue, 2 Sep 2014 16:34:35 +0000 (17:34 +0100)
Fix the following checkpatch warnings.

  WARNING: Missing a blank line after declarations
  WARNING: Prefer kcalloc over kzalloc with multiply

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mxs.c

index 2884f0c..c3f8d3a 100644 (file)
@@ -154,12 +154,14 @@ static int mxs_ssp_wait(struct mxs_spi *spi, int offset, int mask, bool set)
 static void mxs_ssp_dma_irq_callback(void *param)
 {
        struct mxs_spi *spi = param;
+
        complete(&spi->c);
 }
 
 static irqreturn_t mxs_ssp_irq_handler(int irq, void *dev_id)
 {
        struct mxs_ssp *ssp = dev_id;
+
        dev_err(ssp->dev, "%s[%i] CTRL1=%08x STATUS=%08x\n",
                __func__, __LINE__,
                readl(ssp->base + HW_SSP_CTRL1(ssp)),
@@ -189,7 +191,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi,
        if (!len)
                return -EINVAL;
 
-       dma_xfer = kzalloc(sizeof(*dma_xfer) * sgs, GFP_KERNEL);
+       dma_xfer = kcalloc(sgs, sizeof(*dma_xfer), GFP_KERNEL);
        if (!dma_xfer)
                return -ENOMEM;