OSDN Git Service

wifi: ath11k: print a warning when crypto_alloc_shash() fails
authorKalle Valo <quic_kvalo@quicinc.com>
Wed, 5 Apr 2023 09:04:25 +0000 (12:04 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 17 Apr 2023 10:18:57 +0000 (13:18 +0300)
Christoph reported that ath11k failed to initialise when michael_mic.ko
module was not installed. To make it easier to notice that case print a
warning when crypto_alloc_shash() fails.

Compile tested only.

Reported-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/all/20221130133016.GC3055@lst.de/
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230405090425.1351-1-kvalo@kernel.org
drivers/net/wireless/ath/ath11k/dp_rx.c

index 99859b5..d22e534 100644 (file)
@@ -3106,8 +3106,11 @@ int ath11k_peer_rx_frag_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id
        int i;
 
        tfm = crypto_alloc_shash("michael_mic", 0, 0);
-       if (IS_ERR(tfm))
+       if (IS_ERR(tfm)) {
+               ath11k_warn(ab, "failed to allocate michael_mic shash: %ld\n",
+                           PTR_ERR(tfm));
                return PTR_ERR(tfm);
+       }
 
        spin_lock_bh(&ab->base_lock);