OSDN Git Service

cxgb4: fix error return code in cxgb4_set_hash_filter()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 2 Nov 2017 11:15:07 +0000 (11:15 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Nov 2017 05:23:54 +0000 (14:23 +0900)
Fix to return a negative error code from thecxgb4_alloc_atid()
error handling case instead of 0.

Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-By: Kumar Sanghvi <kumaras@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c

index abab67d..5980f30 100644 (file)
@@ -1110,8 +1110,10 @@ static int cxgb4_set_hash_filter(struct net_device *dev,
        }
 
        atid = cxgb4_alloc_atid(t, f);
-       if (atid < 0)
+       if (atid < 0) {
+               ret = atid;
                goto free_smt;
+       }
 
        iconf = adapter->params.tp.ingress_config;
        if (iconf & VNIC_F) {