soc: ti: knav_qmss: Put refcount for dev node in failure case

for_each_child_of_node increases refcount for each device_node and decreases previous one
in a loop, but in case jump out of a loop current node refcount has no chnase for decreases
so requires an of_node_put for jupm out cases.

Fix based on raport from
scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
index 7b5cb5d..591d14e 100644 (file)
--- a/drivers/soc/ti/knav_dma.c
+++ b/drivers/soc/ti/knav_dma.c
@@ -758,6 +758,7 @@ static int knav_dma_probe(struct platform_device *pdev)
        for_each_child_of_node(node, child) {
                ret = dma_init(node, child);
                if (ret) {
+                       of_node_put(child);
                        dev_err(&pdev->dev, "init failed with %d\n", ret);
                        break;
                }

diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index 2e521f1..2ac3856 100644 (file)
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -1087,6 +1087,7 @@ static int knav_queue_setup_regions(struct knav_device *kdev,
        for_each_child_of_node(regions, child) {
                region = devm_kzalloc(dev, sizeof(*region), GFP_KERNEL);
                if (!region) {
+                       of_node_put(child);
                        dev_err(dev, "out of memory allocating region\n");
                        return -ENOMEM;
                }
@@ -1399,6 +1400,7 @@ static int knav_queue_init_qmgrs(struct knav_device *kdev,
        for_each_child_of_node(qmgrs, child) {
                qmgr = devm_kzalloc(dev, sizeof(*qmgr), GFP_KERNEL);
                if (!qmgr) {
+                       of_node_put(child);
                        dev_err(dev, "out of memory allocating qmgr\n");
                        return -ENOMEM;
                }
@@ -1498,6 +1500,7 @@ static int knav_queue_init_pdsps(struct knav_device *kdev,
        for_each_child_of_node(pdsps, child) {
                pdsp = devm_kzalloc(dev, sizeof(*pdsp), GFP_KERNEL);
                if (!pdsp) {
+                       of_node_put(child);
                        dev_err(dev, "out of memory allocating pdsp\n");
                        return -ENOMEM;
                }