Cppcheck: Member variable * is not initialized in the constructor.

diff --git a/Src/Common/Picture.cpp b/Src/Common/Picture.cpp
index fadc5f7..81bedc7 100644 (file)
--- a/Src/Common/Picture.cpp
+++ b/Src/Common/Picture.cpp
@@ -19,7 +19,7 @@ static char THIS_FILE[] = __FILE__;
 // CPicture implementation
 //
 
-CPicture::CPicture()
+CPicture::CPicture() : m_hr(S_OK)
 {
 }
 

diff --git a/Src/CompareEngines/DiffUtils.cpp b/Src/CompareEngines/DiffUtils.cpp
index 09fce50..70d31ae 100644 (file)
--- a/Src/CompareEngines/DiffUtils.cpp
+++ b/Src/CompareEngines/DiffUtils.cpp
@@ -36,6 +36,9 @@ DiffUtils::DiffUtils()
                , m_inf(NULL)
                , m_FilterCommentsManager(new ::FilterCommentsManager)
                , m_pDiffWrapper(new ::CDiffWrapper)
+               , m_ndiffs(0)
+               , m_ntrivialdiffs(0)
+               , m_codepage(0)
 {
 }
 

diff --git a/Src/Merge.cpp b/Src/Merge.cpp
index db001c4..e19efc6 100644 (file)
--- a/Src/Merge.cpp
+++ b/Src/Merge.cpp
@@ -181,6 +181,7 @@ struct ArgSetting
 
 CMergeApp::CMergeApp() :
   m_bNeedIdleTimer(FALSE)
+, m_pOpenTemplate(0)
 , m_pDiffTemplate(0)
 , m_pHexMergeTemplate(0)
 , m_pDirTemplate(0)

diff --git a/Src/OpenView.cpp b/Src/OpenView.cpp
index db48413..96e39c4 100644 (file)
--- a/Src/OpenView.cpp
+++ b/Src/OpenView.cpp
@@ -102,7 +102,7 @@ COpenView::COpenView()
        , m_pUpdateButtonStatusThread(NULL)
        , m_bRecurse(FALSE)
 {
-       // TODO: add construction code here
+       memset(m_dwFlags, 0, sizeof(m_dwFlags));
 }
 
 COpenView::~COpenView()

diff --git a/Src/OpenView.h b/Src/OpenView.h
index 6b1bf0c..e22b3ce 100644 (file)
--- a/Src/OpenView.h
+++ b/Src/OpenView.h
@@ -73,7 +73,6 @@ public:
        /// unpacker info
        DWORD m_dwFlags[3];
        PackingInfo m_infoHandler;
-       BOOL m_bOverwriteRecursive;  /**< If TRUE overwrite last used value of recursive */
 
 // Attributes
 public:

diff --git a/Src/PatchTool.cpp b/Src/PatchTool.cpp
index e591ecb..7f0ad97 100644 (file)
--- a/Src/PatchTool.cpp
+++ b/Src/PatchTool.cpp
@@ -39,7 +39,7 @@ static char THIS_FILE[] = __FILE__;
 /**
  * @brief Default constructor.
  */
-CPatchTool::CPatchTool()
+CPatchTool::CPatchTool() : m_bOpenToEditor(FALSE)
 {
 }
 

diff --git a/Src/Plugins.h b/Src/Plugins.h
index e88393b..f9f7795 100644 (file)
--- a/Src/Plugins.h
+++ b/Src/Plugins.h
@@ -44,7 +44,7 @@ class PluginInfo
 {
 public:
        PluginInfo()
-               : m_lpDispatch(NULL), m_filters(NULL)
+               : m_lpDispatch(NULL), m_filters(NULL), m_bAutomatic(FALSE), m_nFreeFunctions(0)
        {       
        };
        /// Parse the filter string (only for files), and create the filters

diff --git a/Src/ProjectFilePathsDlg.cpp b/Src/ProjectFilePathsDlg.cpp
index 94cec58..21b0461 100644 (file)
--- a/Src/ProjectFilePathsDlg.cpp
+++ b/Src/ProjectFilePathsDlg.cpp
@@ -30,6 +30,7 @@ IMPLEMENT_DYNCREATE(ProjectFilePathsDlg, CPropertyPage)
 ProjectFilePathsDlg::ProjectFilePathsDlg() : CPropertyPage(ProjectFilePathsDlg::IDD)
 , m_bLeftPathReadOnly(FALSE)
 , m_bRightPathReadOnly(FALSE)
+, m_bIncludeSubfolders(FALSE)
 {
        //{{AFX_DATA_INIT(ProjectFilePathsDlg)
        //}}AFX_DATA_INIT