make parse_name a private function, since it's not used in CommandWithUpgrade

also, each implementation returns different things

diff --git a/php/WP_CLI/CommandWithUpgrade.php b/php/WP_CLI/CommandWithUpgrade.php
index 1b34348..7441330 100644 (file)
--- a/php/WP_CLI/CommandWithUpgrade.php
+++ b/php/WP_CLI/CommandWithUpgrade.php
@@ -9,8 +9,6 @@ abstract class CommandWithUpgrade extends \WP_CLI_Command {
        protected $upgrade_refresh;
        protected $upgrade_transient;
 
-       abstract protected function parse_name( $args );
-
        abstract protected function get_item_list();
        abstract protected function get_all_items();
 

diff --git a/php/commands/plugin.php b/php/commands/plugin.php
index 17989e7..e432b46 100644 (file)
--- a/php/commands/plugin.php
+++ b/php/commands/plugin.php
@@ -330,7 +330,7 @@ class Plugin_Command extends \WP_CLI\CommandWithUpgrade {
         * @param array $args
         * @return array
         */
-       protected function parse_name( $args ) {
+       private function parse_name( $args ) {
                $name = $args[0];
 
                $plugins = get_plugins( '/' . $name );

diff --git a/php/commands/theme.php b/php/commands/theme.php
index b5639d2..cabca9d 100644 (file)
--- a/php/commands/theme.php
+++ b/php/commands/theme.php
@@ -216,7 +216,7 @@ class Theme_Command extends \WP_CLI\CommandWithUpgrade {
                parent::_list( $_, $assoc_args );
        }
 
-       protected function parse_name( $args ) {
+       private function parse_name( $args ) {
                $name = $args[0];
 
                $theme = wp_get_theme( $name );