OSDN Git Service

powerpc: don't use ioremap_prot() nor __ioremap() unless really needed.
authorChristophe Leroy <christophe.leroy@c-s.fr>
Tue, 9 Oct 2018 13:51:41 +0000 (13:51 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 14 Oct 2018 07:04:09 +0000 (18:04 +1100)
In many places, ioremap_prot() and __ioremap() can be replaced with
higher level functions like ioremap(), ioremap_coherent(),
ioremap_cache(), ioremap_wc() ...

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/btext.c
arch/powerpc/kernel/crash_dump.c
arch/powerpc/platforms/85xx/smp.c
arch/powerpc/platforms/pasemi/dma_lib.c
arch/powerpc/platforms/ps3/spu.c
arch/powerpc/sysdev/fsl_85xx_cache_sram.c

index b2072d5..b4241ed 100644 (file)
@@ -163,7 +163,7 @@ void btext_map(void)
        offset = ((unsigned long) dispDeviceBase) - base;
        size = dispDeviceRowBytes * dispDeviceRect[3] + offset
                + dispDeviceRect[0];
-       vbase = __ioremap(base, size, pgprot_val(pgprot_noncached_wc(__pgprot(0))));
+       vbase = ioremap_wc(base, size);
        if (!vbase)
                return;
        logicalDisplayBase = vbase + offset;
index d10ad25..bbdc470 100644 (file)
@@ -110,7 +110,7 @@ ssize_t copy_oldmem_page(unsigned long pfn, char *buf,
                vaddr = __va(paddr);
                csize = copy_oldmem_vaddr(vaddr, buf, csize, offset, userbuf);
        } else {
-               vaddr = __ioremap(paddr, PAGE_SIZE, 0);
+               vaddr = ioremap_cache(paddr, PAGE_SIZE);
                csize = copy_oldmem_vaddr(vaddr, buf, csize, offset, userbuf);
                iounmap(vaddr);
        }
index 7e966f4..fff7242 100644 (file)
@@ -216,8 +216,8 @@ static int smp_85xx_start_cpu(int cpu)
 
        /* Map the spin table */
        if (ioremappable)
-               spin_table = ioremap_prot(*cpu_rel_addr,
-                       sizeof(struct epapr_spin_table), _PAGE_COHERENT);
+               spin_table = ioremap_coherent(*cpu_rel_addr,
+                                             sizeof(struct epapr_spin_table));
        else
                spin_table = phys_to_virt(*cpu_rel_addr);
 
index c80f72c..53384eb 100644 (file)
@@ -576,7 +576,7 @@ int pasemi_dma_init(void)
                res.start = 0xfd800000;
                res.end = res.start + 0x1000;
        }
-       dma_status = __ioremap(res.start, resource_size(&res), 0);
+       dma_status = ioremap_cache(res.start, resource_size(&res));
        pci_dev_put(iob_pdev);
 
        for (i = 0; i < MAX_TXCH; i++)
index b548508..7746c2a 100644 (file)
@@ -215,8 +215,7 @@ static int __init setup_areas(struct spu *spu)
                goto fail_ioremap;
        }
 
-       spu->local_store = (__force void *)ioremap_prot(spu->local_store_phys,
-               LS_SIZE, pgprot_val(pgprot_noncached_wc(__pgprot(0))));
+       spu->local_store = (__force void *)ioremap_wc(spu->local_store_phys, LS_SIZE);
 
        if (!spu->local_store) {
                pr_debug("%s:%d: ioremap local_store failed\n",
index 00ccf3e..15cbdd4 100644 (file)
@@ -107,11 +107,11 @@ int __init instantiate_cache_sram(struct platform_device *dev,
                goto out_free;
        }
 
-       cache_sram->base_virt = ioremap_prot(cache_sram->base_phys,
-                               cache_sram->size, _PAGE_COHERENT | PAGE_KERNEL);
+       cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
+                                                cache_sram->size);
        if (!cache_sram->base_virt) {
-               dev_err(&dev->dev, "%pOF: ioremap_prot failed\n",
-                               dev->dev.of_node);
+               dev_err(&dev->dev, "%pOF: ioremap_coherent failed\n",
+                       dev->dev.of_node);
                ret = -ENOMEM;
                goto out_release;
        }