OSDN Git Service

memstick/ms_block: Use the bitmap API when applicable
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 25 Jun 2022 12:56:05 +0000 (14:56 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 12 Jul 2022 10:29:36 +0000 (12:29 +0200)
Use bitmap_equal() instead of hand writing it. It improves semantic and
avoids some explicit computation to convert a number of bits to a number of
bytes.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/b216df8798f765ab14bce65739c220643320f376.1656155715.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/memstick/core/ms_block.c

index f8fdf88..c05edfc 100644 (file)
@@ -2245,8 +2245,8 @@ static int msb_resume(struct memstick_dev *card)
                goto out;
 
        if (msb->block_count != new_msb->block_count ||
-               memcmp(msb->used_blocks_bitmap, new_msb->used_blocks_bitmap,
-                                                       msb->block_count / 8))
+           !bitmap_equal(msb->used_blocks_bitmap, new_msb->used_blocks_bitmap,
+                                                       msb->block_count))
                goto out;
 
        card_dead = false;