OSDN Git Service

net: dsa: vsc73xxx: Get rid of duplicate of_node assignment
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 2 Dec 2021 21:00:29 +0000 (23:00 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Dec 2021 14:13:02 +0000 (14:13 +0000)
GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/vitesse-vsc73xx-core.c

index 4c18f61..ae55167 100644 (file)
@@ -1122,9 +1122,6 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc)
        vsc->gc.ngpio = 4;
        vsc->gc.owner = THIS_MODULE;
        vsc->gc.parent = vsc->dev;
-#if IS_ENABLED(CONFIG_OF_GPIO)
-       vsc->gc.of_node = vsc->dev->of_node;
-#endif
        vsc->gc.base = -1;
        vsc->gc.get = vsc73xx_gpio_get;
        vsc->gc.set = vsc73xx_gpio_set;