Embalm my ideas of how things should work. Not that

anyone will pay attention.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@63155 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/CodeGen/MachineInstr.h b/include/llvm/CodeGen/MachineInstr.h
index 3488ea3..2a3f98d 100644 (file)
--- a/include/llvm/CodeGen/MachineInstr.h
+++ b/include/llvm/CodeGen/MachineInstr.h
@@ -313,6 +313,7 @@ public:
   void setDesc(const TargetInstrDesc &tid) { TID = &tid; }
 
   /// setDebugLoc - Replace current source information with new such.
+  /// Avoid using this, the constructor argument is preferable.
   ///
   void setDebugLoc(const DebugLoc dl) { debugLoc = dl; }
 

diff --git a/include/llvm/CodeGen/SelectionDAGNodes.h b/include/llvm/CodeGen/SelectionDAGNodes.h
index 3aa3f5c..c22b90c 100644 (file)
--- a/include/llvm/CodeGen/SelectionDAGNodes.h
+++ b/include/llvm/CodeGen/SelectionDAGNodes.h
@@ -1154,7 +1154,8 @@ public:
   /// getDebugLoc - Return the source location info.
   const DebugLoc getDebugLoc() const { return debugLoc; }
 
-  /// setDebugLoc - Set source location info.
+  /// setDebugLoc - Set source location info.  Try to avoid this, putting
+  /// it in the constructor is preferable.
   void setDebugLoc(const DebugLoc dl) { debugLoc = dl; }
 
   /// use_iterator - This class provides iterator support for SDUse