OSDN Git Service

dmaengine: edma: fixed wrongly initialized data parameter to the edma callback
authorPetr Kulhavy <petr@barix.com>
Mon, 23 Mar 2015 20:35:01 +0000 (21:35 +0100)
committerVinod Koul <vinod.koul@intel.com>
Wed, 1 Apr 2015 03:45:57 +0000 (09:15 +0530)
The "data" parameter passed indirectly to the edma_callback() should be
edma_chan and not the dma_chan.

This bug was so far harmless since the offset of struct dma_chan within struct
edma_chan is 0. However as soon as someone changes struct edma_chan this would
cause troubles.

Signed-off-by: Petr Kulhavy <petr@barix.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/edma.c

index 276157f..0ea813d 100644 (file)
@@ -805,7 +805,7 @@ static int edma_alloc_chan_resources(struct dma_chan *chan)
        LIST_HEAD(descs);
 
        a_ch_num = edma_alloc_channel(echan->ch_num, edma_callback,
-                                       chan, EVENTQ_DEFAULT);
+                                       echan, EVENTQ_DEFAULT);
 
        if (a_ch_num < 0) {
                ret = -ENODEV;