OSDN Git Service

scsi: sg: remove bad blk_end_request_all() call
authorJens Axboe <axboe@kernel.dk>
Tue, 16 Oct 2018 14:38:47 +0000 (08:38 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Oct 2018 21:49:57 +0000 (17:49 -0400)
We just need to free the request here. Additionally, this is currently
wrong for a queue that's using MQ currently, it'll crash.

Cc: Doug Gilbert <dgilbert@interlog.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sg.c

index 8a254bb..c6ad007 100644 (file)
@@ -822,7 +822,7 @@ sg_common_write(Sg_fd * sfp, Sg_request * srp,
        if (atomic_read(&sdp->detaching)) {
                if (srp->bio) {
                        scsi_req_free_cmd(scsi_req(srp->rq));
-                       blk_end_request_all(srp->rq, BLK_STS_IOERR);
+                       blk_put_request(srp->rq);
                        srp->rq = NULL;
                }