OSDN Git Service

zd1211rw: Remove in_atomic() usage.
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Sun, 1 Nov 2020 21:15:34 +0000 (22:15 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 7 Nov 2020 15:52:23 +0000 (17:52 +0200)
The usage of in_atomic() in driver code is deprecated as it can not
always detect all states where it is not allowed to sleep.

All callers are in premptible thread context and all functions invoke core
functions which have checks for invalid calling contexts already.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Ulrich Kunitz <kune@deine-taler.de>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201101211536.2966644-7-bigeasy@linutronix.de
drivers/net/wireless/zydas/zd1211rw/zd_usb.c

index 66367ab..5c4cd0e 100644 (file)
@@ -1711,11 +1711,6 @@ int zd_usb_ioread16v(struct zd_usb *usb, u16 *values,
                         count, USB_MAX_IOREAD16_COUNT);
                return -EINVAL;
        }
-       if (in_atomic()) {
-               dev_dbg_f(zd_usb_dev(usb),
-                        "error: io in atomic context not supported\n");
-               return -EWOULDBLOCK;
-       }
        if (!usb_int_enabled(usb)) {
                dev_dbg_f(zd_usb_dev(usb),
                          "error: usb interrupt not enabled\n");
@@ -1882,11 +1877,6 @@ int zd_usb_iowrite16v_async(struct zd_usb *usb, const struct zd_ioreq16 *ioreqs,
                        count, USB_MAX_IOWRITE16_COUNT);
                return -EINVAL;
        }
-       if (in_atomic()) {
-               dev_dbg_f(zd_usb_dev(usb),
-                       "error: io in atomic context not supported\n");
-               return -EWOULDBLOCK;
-       }
 
        udev = zd_usb_to_usbdev(usb);
 
@@ -1966,11 +1956,6 @@ int zd_usb_rfwrite(struct zd_usb *usb, u32 value, u8 bits)
        int i, req_len, actual_req_len;
        u16 bit_value_template;
 
-       if (in_atomic()) {
-               dev_dbg_f(zd_usb_dev(usb),
-                       "error: io in atomic context not supported\n");
-               return -EWOULDBLOCK;
-       }
        if (bits < USB_MIN_RFWRITE_BIT_COUNT) {
                dev_dbg_f(zd_usb_dev(usb),
                        "error: bits %d are smaller than"