OSDN Git Service

drm/gma500: fix a potential repeat execution in psb_driver_load
authorXiaomeng Tong <xiam0nd.tong@gmail.com>
Wed, 13 Apr 2022 05:11:05 +0000 (13:11 +0800)
committerPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Wed, 20 Apr 2022 07:11:01 +0000 (09:11 +0200)
Instead of exiting the loop as expected when an entry is found, the
list_for_each_entry() continues until the traversal is complete. To
avoid potential executing 'ret = gma_backlight_init(dev);' repeatly,
goto outside the loop when found entry by replacing switch/case with
if statement.

Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
[Fixed indentation]
Link: https://patchwork.freedesktop.org/patch/msgid/20220413051105.5612-1-xiam0nd.tong@gmail.com
drivers/gpu/drm/gma500/psb_drv.c

index 2aff54d..1d8744f 100644 (file)
@@ -396,9 +396,8 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
        drm_for_each_connector_iter(connector, &conn_iter) {
                gma_encoder = gma_attached_encoder(connector);
 
-               switch (gma_encoder->type) {
-               case INTEL_OUTPUT_LVDS:
-               case INTEL_OUTPUT_MIPI:
+               if (gma_encoder->type == INTEL_OUTPUT_LVDS ||
+                   gma_encoder->type == INTEL_OUTPUT_MIPI) {
                        ret = gma_backlight_init(dev);
                        break;
                }