OSDN Git Service

[media] cx231xx: simplify I2C scan debug messages
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sun, 2 Nov 2014 11:34:34 +0000 (08:34 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 3 Nov 2014 17:59:35 +0000 (15:59 -0200)
Don't need to show when it starts or stops. Just print lines
when devices are found.

After the changes, the output for i2c scan will be like:

usb 1-2: i2c scan: found device @ port 0 addr 0x40  [???]
usb 1-2: i2c scan: found device @ port 0 addr 0x60  [colibri]
usb 1-2: i2c scan: found device @ port 0 addr 0x88  [hammerhead]
usb 1-2: i2c scan: found device @ port 0 addr 0x98  [???]
usb 1-2: i2c scan: found device @ port 3 addr 0xa0  [eeprom]
usb 1-2: i2c scan: found device @ port 2 addr 0x60  [colibri]
usb 1-2: i2c scan: found device @ port 2 addr 0xc0  [tuner]
usb 1-2: i2c scan: found device @ port 4 addr 0x20  [demod]

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/cx231xx/cx231xx-i2c.c

index 87b2615..7ccc33d 100644 (file)
@@ -502,21 +502,17 @@ void cx231xx_do_i2c_scan(struct cx231xx *dev, int i2c_port)
        memset(&client, 0, sizeof(client));
        client.adapter = cx231xx_get_i2c_adap(dev, i2c_port);
 
-       dev_info(&dev->udev->dev,
-               "i2c_scan: checking for I2C devices on port=%d ..\n",
-               i2c_port);
        for (i = 0; i < 128; i++) {
                client.addr = i;
                rc = i2c_master_recv(&client, &buf, 0);
                if (rc < 0)
                        continue;
                dev_info(&dev->udev->dev,
-                        "i2c scan: found device @ 0x%x  [%s]\n",
+                        "i2c scan: found device @ port %d addr 0x%x  [%s]\n",
+                        i2c_port,
                         i << 1,
                         i2c_devs[i] ? i2c_devs[i] : "???");
        }
-       dev_info(&dev->udev->dev, "i2c scan: Completed Checking for I2C devices on port=%d.\n",
-               i2c_port);
 
        dev->i2c_scan_running = false;
 }